[PATCH] D112870: [MergeFunctions] Extend FunctionComparator to account for metadata arguments in intrinsics, and only ignore debug info metadata

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FunctionComparator.cpp:730
+  // identity.
+  return L < R ? -1 : 1;
+}
----------------
I'm concerned that this is going to cause non-determinism, because addresses are not stable. I think we need to either look into the metadata, or assign numbers (like GlobalNumberState).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112870/new/

https://reviews.llvm.org/D112870