[PATCH] D114873: [SLP]Introduce isUndefVector function to check for undef vectors.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 1 06:53:21 PST 2021


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:293
+    return false;
+  if (!C->containsUndefOrPoisonElement() || !isa<FixedVectorType>(C->getType()))
+    return false;
----------------
remove the isa<> - the dyn_cast below handles it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114873/new/

https://reviews.llvm.org/D114873



More information about the llvm-commits mailing list