[PATCH] D114841: [lld-macho] Fix duplicate symbols with relocatable objects

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/Driver.cpp:253
                           bool isExplicit = true, bool isBundleLoader = false) {
+  // Avoid loading archives twice. If the archives are being force-loaded,
+  // loading them twice would create duplicate symbol errors. In the
----------------
nit: no longer applying only to archives


================
Comment at: lld/test/MachO/framework-object.ll:11
+; RUN: llvm-as %t/load-framework-foo.ll -o %t/main
+; RUN: %lld %t/main -F %t -framework Foo -framework Foo
+
----------------
could you spell out the output here to be either /dev/null or `%t/...` ?
(without it, it'd put the output in location not actually writeable on our build machines and that'd cause problems during integrates)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114841/new/

https://reviews.llvm.org/D114841