[PATCH] D113782: [SLP]Improve cost model for the shuffled extracts.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5425
+            } while (E == getTreeEntry(Base));
+          }
+          FirstUsers.push_back(VU);
----------------
RKSimon wrote:
> Should this be put inside the while() loop before the break? AFAICT that's the only time that cast<InsertElementInst>(Base) is valid.
No, not quite so. It can be insertelement also if `ScalarToTreeEntry.count(Base)` is true, i.e. there is a tree entry for this insertelement in the graph.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113782/new/

https://reviews.llvm.org/D113782