[PATCH] D114858: [AArch64][SVE] Enable bf16 vector.insert

[Matt Devereau via Phabricator via llvm-commits]

MattDevereau added a comment.

In D114858#3164008 <https://reviews.llvm.org/D114858#3164008>, @paulwalker-arm wrote:

> In D114858#3163966 <https://reviews.llvm.org/D114858#3163966>, @MattDevereau wrote:
>
>> In D114858#3163710 <https://reviews.llvm.org/D114858#3163710>, @paulwalker-arm wrote:
>>
>>> Do the tests have to live in a new file instead of sitting alongside the other variants in sve-insert-vector.ll? I see nothing SVE2 related here.
>>
>> I saw `#if defined(__ARM_FEATURE_SVE2) && defined(__ARM_FEATURE_SVE_BF16)` in another file so assumed bf16 was SVE2 only
>
> That will be to protect SVE2 specific BF16 instructions. SVE also has BF16 instructions, for example BFDOT.  These tests only really care about the type as no BF16 related instructions are necessary so they can all sit within the same file. For a similar example see sve-vector-splat.ll.

I realise that now since I ran some tests with sve+bf16 and they work fine. I'll move these back into the previous file :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114858/new/

https://reviews.llvm.org/D114858