[PATCH] D114844: [X86][FP16] Only generate approximate rsqrt when Reciprocal is true for half type
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 1 02:52:22 PST 2021
RKSimon added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23243
Subtarget.hasFP16()) {
+ assert(Reciprocal && "Don't replace SQRT with RSQRT for half type");
if (RefinementSteps == ReciprocalEstimate::Unspecified)
----------------
Do we have test coverage for this path? A quick grep didn't find anything other than the intrinsics test files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114844/new/
https://reviews.llvm.org/D114844
More information about the llvm-commits
mailing list