[PATCH] D114159: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 1

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 1 01:41:22 PST 2021


clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2312
+              loadStrideFromBox(loc, operands[0], index - i, rewriter);
+          auto sc = rewriter.create<mlir::LLVM::MulOp>(
+              loc, idxTy, operands[index], stride);
----------------
Can you fix the clang-format here?


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2333
+            loc, mlir::LLVM::LLVMPointerType::get(llvmCurrentObjTy), args);
+        resultAddr = rewriter.create<mlir::LLVM::BitcastOp>(loc, voidPtrTy, gep);
+      } else {
----------------
format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114159/new/

https://reviews.llvm.org/D114159



More information about the llvm-commits mailing list