[PATCH] D114801: [ELF] Prevent internalizing used comdat symbol

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM. Previously `resolve` sets the `isUsedInRegularObj` bit. `replace` loses the bit.



================
Comment at: lld/test/ELF/lto/comdat-mixed-archive.test:48
+
+;; Note. "foo" is defined after declaring "bar" so that loading the regular
+;; object file "obj.o" is triggered before processing the definition of "foo".
----------------
Maybe use `llvm-nm %bc.o` to test the symbol order.

You can also name the bitcode `*.bc` to be different from relocatable object files.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114801/new/

https://reviews.llvm.org/D114801