[PATCH] D114434: [NFC][XCOFF] [llvm-readobj] replace binaries with YAMLs (only tests for Symbols)

Tue Nov 30 22:46:57 PST 2021

shchenz accepted this revision.
shchenz added a comment.

LGTM too. Thanks for cleaning up.

================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:115
+# SYMBOL64-NEXT:       Index: 5
+# SYMBOL64-NEXT:       SectionLen: 21474836484
+# SYMBOL64-NEXT:       ParameterHashIndex: 0x2
----------------
Esme wrote:
> shchenz wrote:
> > The length seems not right to me.
> The length value is correct in fact. 
> The section length value in the CSECT Auxiliary Entry for XCOFF64 is composed of two fields, i.e. x_scnlen_lo and x_scnlen_hi, that are SectionOrLengthLo and SectionOrLengthHi in YAML.
> I set `SectionOrLengthLo:      4` and `SectionOrLengthHi:      5` in YAML,  and 21474836484 equals to 0x500000004, so the value is right.
Ah, OK. I didn't notice that this big length is coming from the YAML. Thanks for the explanation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114434/new/

https://reviews.llvm.org/D114434