[PATCH] D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC

Tue Nov 30 16:54:03 PST 2021

MaskRay added a comment.

In D114186#3159538 <https://reviews.llvm.org/D114186#3159538>, @tstellar wrote:

> I'm asking for the behavior to be changed back, because 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> goes against the LLVM developer policy.    If you want to make a technical argument about why 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> should stay in, then you need to convince @jrtc27 and others who object to this change to drop their objections and state that on one of the reviews.

@tstellar This claim will harm my fame so I have to defend.

bd1976llvm gave me this in April:
"Thanks for the warning about changing the default to -z start-stop-gc. I have read your excellent blog entry explaining about it 🙂 This doesn't seem to cause any problems with the test code I have. I think we are pretty happy with the change given that we can offer work-arounds in the rare case that any games are affected. If we find any interesting problems caused by -z start-stop-gc I will let you know."
Then-Facebook was informed in February.
@dim and @emaste were informed in March 1. The initial message I sent to them used "In a future release" not saying 13.0.0 was my mistake. And giving a second-round heads-up when the change was pushed was my mistake, too.

As a hindsight, it'd be much better if I created a patch CCing all the relevant folks, and I screwed up something (and clearly failed on ldc/NetworkManager) but I don't necessarily agree with your  LLVM developer policy claim.

---

For origin/release/13.x you have the final discretion. I just want to repeat that some distributions have built lld 13.0.0 for more than one month now and Gentoo Linux users doing (GCC/Clang LDFLAGS=-fuse-ld=lld) is fine.

For origin/main I request higher standard for a revert. They need to provide more evidence. We should all keep in mind that the commit has been there fore 7 months and rolling release users have been well served.
(I may not be around on Thursday/Friday.)

If that is still not sufficient, I created D114830 <https://reviews.llvm.org/D114830> to give the user more hints.

To be honest I think this CMake change unnecessary and I hope we can avoid it for origin/main.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114186/new/

https://reviews.llvm.org/D114186