[PATCH] D114783: [ELF] Split scanRelocations into scanRelocations/postScanRelocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Symbols.h:284
+  uint8_t needsPlt : 1;
+  uint8_t needsNonGotPlt : 1;
+
----------------
peter.smith wrote:
> perhaps needsCanonicalPlt?
needsCopy indicates whether copy relocations/canonical PLT entries are needed for non-ifunc symbols.

hasDirectReloc indicates whether canonical PLT entry is needed for ifunc. hasDirectReloc needs to be true even for isStaticLinkTimeConstant relocations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114783/new/

https://reviews.llvm.org/D114783