[PATCH] D114410: [ObjectYAML/obj2yaml/yaml2obj][MachO] Support indirect symbol table

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 15:03:20 PST 2021


thevinster marked 4 inline comments as done.
thevinster added inline comments.


================
Comment at: llvm/test/ObjectYAML/MachO/dsymtab.yaml:3
+
+--- !mach-o
+FileHeader:
----------------
jhenderson wrote:
> Is this the minimum this document can be reduced to? There's a lot of stuff that has no value to the test, although I know that Mach-O yaml2obj's side doesn't allow much to be removed to minimise noise.
Updated. Most of the LinkEditData could be removed (except the one under test), but the FileHeader and LoadCommands are required in order to not break the continuity of the binary. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114410/new/

https://reviews.llvm.org/D114410



More information about the llvm-commits mailing list