[PATCH] D113187: Improve unsupported lit test config for print-changed=dot-cfg

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 14:23:15 PST 2021


hvdijk accepted this revision.
hvdijk added a comment.
This revision is now accepted and ready to land.

Apologies, forgot about this, and thanks. I personally think it might have been slightly simpler to check whether `dot -Tpdf </dev/null` (or an equivalent that avoids the shell) exits successfully, instead of having to parse `dot`'s output, but since you already have it working this way, I'm also okay if you want to leave it as it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113187/new/

https://reviews.llvm.org/D113187



More information about the llvm-commits mailing list