[PATCH] D114558: [ASan] Shared optimized callbacks implementation.

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_rtl_x86_64.S:42
+        pop    %rcx ;\
+        jl     RLABEL(reg, op, 1, i);\
+        mov    %##reg,%rdi ;\
----------------
Maybe I've confused myself, but isn't this condition opposite of what we want?

```
if (last_accessed_byte >= shadow_value) crash()
```
would translate to
```
cmp %ecx, %r8d
...
jl RLABEL(...)
```
or 
```
cmp %r8d, %ecx
...
jg RLABEL(...)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114558/new/

https://reviews.llvm.org/D114558