[PATCH] D114818: [libunwind] Fix unwind_leaffunction test
Leonard Chan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 30 13:17:19 PST 2021
leonardchan accepted this revision.
leonardchan added a comment.
I haven't yet responded on D114385 <https://reviews.llvm.org/D114385>, but it looks like using `__builtin_trap()` still breaks the test for us because the unwinder doesn't iterate over the frame for `main`. Instead it goes from `crashing_leaf_func` to `__libc_start_main`, then runs out of frames. I'm still investigating why it does this. I don't think that should be a blocker for landing this though since this approach seems more correct than the `raise`, so LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114818/new/
https://reviews.llvm.org/D114818
More information about the llvm-commits
mailing list