[PATCH] D113785: [llvm-profgen] Trim cold function profiles for non-CS AutoFDO

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-noprobe2.test:89
 ;CHECK-NEXT:  6: 24
 ;CHECK-NEXT: main:52:0
 ;CHECK-NEXT:  0: 0
----------------
Here


================
Comment at: llvm/test/tools/llvm-profgen/inline-noprobe2.test:111
+;CHECK-TRIM-COLD-NOT: quick_sort:83:25
+;CHECK-TRIM-COLD-NOT: main:52:0
+
----------------
wenlei wrote:
> wlei wrote:
> > > None of the tests cover trim vs no-trim difference, it'd be good to have one, so we check trimming is actually making a difference.
> > 
> > @wenlei  We do have a test case for the trimming here which checked the function won't appear if its total sample is smaller than `--profile-summary-cold-count=100`
> But we don't have a check to make sure main/quick_sort actually appears without trimming, right? If for whatever reason these two never appears even without trimming (--trim-cold-profile=0), this test could be doing nothing. 
Oh, I got your meaning. In the test above, there is a CHECK for main/quick_sort, but I realize it's mixed with other test and not visible. I will add a separate test case for cold trimming.Thanks for the clarification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113785/new/

https://reviews.llvm.org/D113785