[PATCH] D114087: [SLP]Improve registering and merging of compatible shuffles.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6871
+          eraseInstruction(V);
+          if (auto *SI = dyn_cast<ShuffleVectorInst>(&In))
+            if (!NewMask.empty())
----------------
RKSimon wrote:
> Can't we remove this dyn_cast thanks to the isa<> test above?
No, we need `SI` here of `ShuffleVectorInst` type to be able to replace its shuffle mask.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114087/new/

https://reviews.llvm.org/D114087