[PATCH] D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/MemProfData.inc:24
+
+#ifdef _MSC_VER
+#define PACKED(__decl__) __pragma(pack(push,1)) __decl__ __pragma(pack(pop))
----------------
davidxl wrote:
> It would be ideal to have the macro defined in a common header, but it is probably difficult because the .inc file is for both llvm and runtime.
Yes, there are no headers shared between LLVM and compiler-rt so it would have to be duplicated. Since memprof is the only place where this is used I will leave it in the shared .inc files as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114286/new/

https://reviews.llvm.org/D114286