[PATCH] D112463: [LangRef] Remove incorrect vector alignment rules

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 09:12:17 PST 2021


aeubanks added inline comments.


================
Comment at: llvm/unittests/IR/DataLayoutTest.cpp:94
+TEST(DataLayoutTest, VectorAlign) {
+  Expected<DataLayout> DL = DataLayout::parse("v128:128");
+  EXPECT_THAT_EXPECTED(DL, Succeeded());
----------------
I'm not very familiar with vectors, but does this say that a 128-bit vector is a legal type? Then this wouldn't be testing the langref change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112463/new/

https://reviews.llvm.org/D112463



More information about the llvm-commits mailing list