[PATCH] D114478: [TLI checker] Update for post-commit review comments

[Paul Robinson via Phabricator via llvm-commits]

probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: llvm/tools/llvm-tli-checker/llvm-tli-checker.cpp:169
   if (!O->isELF()) {
-    WithColor::warning() << "Only ELF-format files are supported\n";
+    WithColor::warning() << "only ELF-format files are supported\n";
     return;
----------------
jhenderson wrote:
> probinson wrote:
> > jhenderson wrote:
> > > jhenderson wrote:
> > > > If the tool can take more than one input (I haven't checked if it can), it might be wise to include the filename in this message.
> > > Usual format is "warning: file name: message" (see what `FileError` does for a comparison).
> > Updated to put filename first, here and elsewhere.
> Is this warning message tested anywhere? I don't see it immediately, and I'd expect test failures if it were tested elsewhere due to the format change. Same goes for the other warnings/errors reported in this file.
None of the malformed-input messages are tested.
Neither are multiple inputs, or using an archive as input.
I'd prefer to defer those to a separate patch if that's okay.  You know where to find me, it'll happen. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114478/new/

https://reviews.llvm.org/D114478