[PATCH] D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX

[Yousuf via Phabricator via llvm-commits]

yoalione marked 2 inline comments as done.
yoalione added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5832
+
+    if (isPPC64 && isAIXABI && CModel == CodeModel::Small) {
+      if (hasTocDataAttr(N->getOperand(0),
----------------
nemanjai wrote:
> The `isAIXABI` check here should be unnecessary since we would break out of here at line 5795. I think it would be clearer if we just add an assert for `isAIXABI` just above this line instead.
I think it should be within the `if` (so a line after).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114654/new/

https://reviews.llvm.org/D114654