[PATCH] D114581: [RISCV] Decode vtype with reserved fields to raw immediate

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 07:00:56 PST 2021


benshi001 added a comment.

In D114581#3161366 <https://reviews.llvm.org/D114581#3161366>, @jrtc27 wrote:

> And not sure why you committed this with "Reviewed By: jhenderson, jrtc27, craig.topper", Craig was the only one to approve it, and James somewhat by saying an older version of the test looked fine

I am not clear about the rule of  the `Reviewed By:` list is only for who approve patches. Since you and Craig and James made comments, I thought you all have read (==reviewed) the code. I will pay attention to that next time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114581/new/

https://reviews.llvm.org/D114581



More information about the llvm-commits mailing list