[PATCH] D114766: If constrained intrinsic is replaced, remove its side effect

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 06:27:17 PST 2021


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

Marking as changes requested per above comment -- really don't think this is the right place to address this, since it will just create an incorrect picture of what LLVM can optimize in practice. Usually, this fold will happen via InstCombine rather than InstSimplifyPass. But I don't think changing InstCombine is the right solution either, as any number of passes do this kind of "simplify and DCE" pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114766/new/

https://reviews.llvm.org/D114766



More information about the llvm-commits mailing list