[PATCH] D114795: [PR52475] Ensure a correct chain in copies to/from hidden sret parameter

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added a comment.

In D114795#3161370 <https://reviews.llvm.org/D114795#3161370>, @jrtc27 wrote:

> Presumably this only affects //IR// with wacky return types, because Clang inserts an explicit sret parameter in the IR it generates when the ABI needs it?

I wouldn't want to say definitively but yeah that's roughly how I see things. I don't know if that's a //requirement// (documented or otherwise) of clang or not, though.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/pr52475.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64 -mattr=+experimental-v -riscv-v-vector-bits-min=128 -riscv-v-fixed-length-vector-lmul-max=4 \
+; RUN:   -pre-RA-sched=list-burr -disable-machine-cse -verify-machineinstrs < %s | FileCheck %s
----------------
jrtc27 wrote:
> RV32?
Good catch, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114795/new/

https://reviews.llvm.org/D114795