[PATCH] D114792: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions

[David Stuttard via Phabricator via llvm-commits]

dstuttard added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-bvh.mir:3
+
+...
+name: waitcnt-check-inorder
----------------
foad wrote:
> I think the canonical YAML format is to have `---` before each function and `...` after it, like this:
> ```
> ---
> function goes here
> ...
> ```
Ok


================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-bvh.mir:7
+  bb.0:
+    ; GCN-LABEL: name: waitcnt-check-inorder
+    ; GCN: $vgpr0_vgpr1_vgpr2_vgpr3 = IMAGE_BVH_INTERSECT_RAY_sa_gfx10 killed $vgpr4_vgpr5_vgpr6_vgpr7_vgpr8_vgpr9_vgpr10_vgpr11_vgpr12_vgpr13_vgpr14_vgpr15_vgpr16_vgpr17_vgpr18_vgpr19
----------------
foad wrote:
> It looks like these checks are (or could be?) autogenerated, but there's no "autogenerated by" comment on line 1.
They weren't autogenerated - but that's a good point, there's no reason why not. I'll update it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114792/new/

https://reviews.llvm.org/D114792