[llvm] 3c04507 - [DebugInfo] Turn instruction referencing on by default for x86

[Jeremy Morse via llvm-commits]

Author: Jeremy Morse
Date: 2021-11-30T13:44:07Z
New Revision: 3c045070882f3f43135da6a40ef3f6508fe43af6

URL: https://github.com/llvm/llvm-project/commit/3c045070882f3f43135da6a40ef3f6508fe43af6
DIFF: https://github.com/llvm/llvm-project/commit/3c045070882f3f43135da6a40ef3f6508fe43af6.diff

LOG: [DebugInfo] Turn instruction referencing on by default for x86

This patch is designed to be reverted -- it activates a reasonably large
block of new-ish code, so some turbulence is likely.

Instruction referencing is best summarised, and it being on-by-default,
is discussed here:

    https://lists.llvm.org/pipermail/llvm-dev/2021-November/153653.html

Differential Revision: https://reviews.llvm.org/D114631

Added: 
    

Modified: 
    llvm/lib/CodeGen/CommandFlags.cpp
    llvm/test/DebugInfo/X86/instr-ref-flag.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/CommandFlags.cpp b/llvm/lib/CodeGen/CommandFlags.cpp
index ecf3d931fc33b..3bed81d5841d1 100644
--- a/llvm/lib/CodeGen/CommandFlags.cpp
+++ b/llvm/lib/CodeGen/CommandFlags.cpp
@@ -699,5 +699,7 @@ void codegen::setFunctionAttributes(StringRef CPU, StringRef Features,
 }
 
 bool codegen::getDefaultValueTrackingVariableLocations(const llvm::Triple &T) {
+  if (T.getArch() == llvm::Triple::x86_64)
+    return true;
   return false;
 }

diff  --git a/llvm/test/DebugInfo/X86/instr-ref-flag.ll b/llvm/test/DebugInfo/X86/instr-ref-flag.ll
index b496bc418dec9..f9d5f99edf77f 100644
--- a/llvm/test/DebugInfo/X86/instr-ref-flag.ll
+++ b/llvm/test/DebugInfo/X86/instr-ref-flag.ll
@@ -13,10 +13,6 @@
 ;; by llc by default, and that it can be turned explicitly on or off as
 ;; desired.
 
-;; XFail it for pre-landing the patch, and to allow a minimal delta if it
-;; has to be reverted.
-; XFAIL: *
-
 ; INSTRREFON: DBG_INSTR_REF
 ; INSTRREFOFF: DBG_VALUE