[PATCH] D112982: [MLIR][OpenMP] Added omp.atomic.update

[Shraiysh via Phabricator via llvm-commits]

shraiysh added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:624
+                       AnyType:$expr,
+                       UnitAttr:$isXBinopExpr,
+                       AtomicBinOpKindAttr:$binop,
----------------
kiranchandramohan wrote:
> Are any non-binary operations supported currently? If not, can this be removed? If yes, can a test be added?
This is the naming issue from earlier. The name here means "is it of the form `X binop expr`". The value false implies that it is of the form `expr binop X`. The previous name for this variable was `isXLhsinRhsPart` but that was confusing too. This is not a flag for it being a binop expression or not. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112982/new/

https://reviews.llvm.org/D112982