[PATCH] D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

My comments are just minor nits that don't require another review and can be addressed when committing the patch.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5832
+
+    if (isPPC64 && isAIXABI && CModel == CodeModel::Small) {
+      if (hasTocDataAttr(N->getOperand(0),
----------------
The `isAIXABI` check here should be unnecessary since we would break out of here at line 5795. I think it would be clearer if we just add an assert for `isAIXABI` just above this line instead.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:776
 
+let isCodeGenOnly = 1 in
+def LA8     : DForm_2<14, (outs g8rc:$rD), (ins g8rc_nox0:$rA, s16imm64:$sym),
----------------
This is already in a `isCodeGenOnly = 1` block isn't it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114654/new/

https://reviews.llvm.org/D114654