[PATCH] D114324: [LV] Move code from vectorizeMemoryInstruction to recipe's execute().

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9926
+      if (Reverse)
+        NewLI = Builder.CreateVectorReverse(NewLI, "reverse");
+    }
----------------
Ayal wrote:
> The `assert(Vec->getType()->isVectorTy() && "Invalid type");` of reverseVector() being dropped will be taken care of by Builder.CreateVectorReverse() anyhow?
`CreateVectorReverse` has `  auto *Ty = cast<VectorType>(V->getType());` which should be equivalent to the assert.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9934
+  /*&Ingredient, State, StoredValue ? nullptr : getVPSingleValue(), getAddr(),*/
+  /*StoredValue, getMask(), Consecutive, Reverse);*/
 }
----------------
Ayal wrote:
> clean up above comments?
Removed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114324/new/

https://reviews.llvm.org/D114324