[PATCH] D114748: [ELF] Change -z unknown from error to warning

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 02:49:15 PST 2021


peter.smith accepted this revision.
peter.smith added a comment.

LGTM too, good to match GNU ld behaviour where possible. One stale comment spotted but easy to fix up prior to commit.



================
Comment at: lld/ELF/Driver.cpp:464
 // Report an error for an unknown -z option.
 static void checkZOptions(opt::InputArgList &args) {
   for (auto *arg : args.filtered(OPT_z))
----------------
Comment is now stale as we're not reporting an error. Perhaps
// Report a warning for an unknown -z option to match ld.bfd behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114748/new/

https://reviews.llvm.org/D114748



More information about the llvm-commits mailing list