[PATCH] D114777: [AMDGPU] Set most sched model resource's BufferSize to one

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 02:33:45 PST 2021


foad added a comment.

I am mostly in favour of this change just because I never understood how setting BufferSize to (say) 15 bore any relation to that fact that we can have 15 VMEM loads in flight at once. In fact I really don't understand what effect all these different ProcResources have. I think they will stop the scheduler from trying to issue two different (say) VMEM instructions in the same cycle, because they both need to use the same resource; but we have already set IssueWidth = 1, so the scheduler should already know that it can't issue any two instructions in the same cycle.

Incidentally in D87621 <https://reviews.llvm.org/D87621> we discussed whether most resources should use BufferSize = 0 or 1. I am still unsure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114777/new/

https://reviews.llvm.org/D114777



More information about the llvm-commits mailing list