[PATCH] D112758: [llvm] [Debuginfo] Debuginfod client library.

[Pavel Labath via Phabricator via llvm-commits]

labath added inline comments.


================
Comment at: llvm/include/llvm/Debuginfod/Debuginfod.h:42
+/// DEBUGINFOD_TIMEOUT environment variable, default is 90 seconds (90000 ms).
+long getDefaultDebuginfodTimeoutMS();
+
----------------
noajshu wrote:
> labath wrote:
> > how about returning `std::chrono::milliseconds` instead?
> Sure, I've updated this. By the way, do you think the `HTTPClient.setTimeout` should accept `std::chrono::milliseconds` as well? If so I can update D112751 and D112753. Otherwise, it just converts back to an integer using `.count()` before passing to `setTimeout`.
Yes, I'd use it in all APIs that we control, and only convert it to int (or whatever) when we're passing it to curl. That way we can avoid questions like <https://reviews.llvm.org/D112758#inline-1095701>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112758/new/

https://reviews.llvm.org/D112758