[PATCH] D111337: [fir] Add array value copy pass

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 01:41:23 PST 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

LGTM.



================
Comment at: flang/lib/Optimizer/Builder/FIRBuilder.cpp:119
     auto attr = getFloatAttr(fltTy, value);
-    return create<mlir::arith::ConstantOp>(loc, fltTy, attr);
+    return create<mlir::ConstantOp>(loc, fltTy, attr);
   }
----------------
Nit: Is this change necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337



More information about the llvm-commits mailing list