[PATCH] D114778: [XCOFF][FastISel] make fast isel can lower general intrinsics

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:1784
+    // But fast isel still have the ability to do selection for intrinsics.
+    if (TM.getTargetTriple().isOSAIX() && !dyn_cast<IntrinsicInst>(I))
       return false;
----------------
- In this case, no extra instruction will be really emitted from this intrinsic, but what if it's an intrinsic producing a real function call?
- Is it necessary to put the check here, not in `PPCFastISel::fastSelectInstruction`?


================
Comment at: llvm/test/CodeGen/PowerPC/debug-label-fast-isel.ll:2
+
+; RUN: llc %s -mtriple powerpc64-ibm-aix-xcoff -o - | FileCheck %s --check-prefix=CHECKASM
+
----------------
nit: remove top empty line and use `llc < %s -mtriple ... | FileCheck ...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114778/new/

https://reviews.llvm.org/D114778