[PATCH] D113825: [llvm-readobj][XCOFF] dump auxiliary symbols.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 30 00:37:42 PST 2021
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols-invalid.test:52
-# RUN: yaml2obj %s -o %t
-# RUN: llvm-readobj --syms %t | FileCheck %s
-
-# CHECK: Symbols [
-# CHECK-NEXT: Symbol {
-# CHECK-NEXT: Index: 0
-# CHECK-NEXT: Name: .fun
-# CHECK-NEXT: Value (SymbolTableIndex): 0x0
-# CHECK-NEXT: Section: N_UNDEF
-# CHECK-NEXT: Source Language ID: TB_C (0x0)
-# CHECK-NEXT: CPU Version ID: 0x0
-# CHECK-NEXT: StorageClass: C_FILE (0x67)
-# CHECK-NEXT: NumberOfAuxEntries: 1
-# CHECK-NEXT: !Unexpected raw auxiliary entry data:
-# CHECK-NEXT: 00000000 00000001 00020300 00000000 00fb
-# CHECK-NEXT: }
-# CHECK-NEXT: ]
+ # CASE8:Symbols [
+# CASE8-NEXT: Symbol {
----------------
You can leave the `#` in the right place, and just add spaces to pad.
================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:67
+template <typename T, typename TEnum>
+static std::string enum2String(T Value,
+ ArrayRef<EnumEntry<TEnum>> EnumValues) {
----------------
I'm slightly surprised this doesn't already exist in our code? Have you copied it from somewhere? If so, where, and could you just move such a function declaration into a common header for reuse?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113825/new/
https://reviews.llvm.org/D113825
More information about the llvm-commits
mailing list