[PATCH] D114646: [LV] Pass compare predicate to getCmpSelInstrCost.

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Makes sense to me, but I'm not sure what the original comment about being composed of different predicates meant. The aarch64 backend is already doing this from I in some situations, but won't if the vector and scalar types do not match.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7956
     return TTI.getCmpSelInstrCost(I->getOpcode(), VectorTy, nullptr,
                                   CmpInst::BAD_ICMP_PREDICATE, CostKind, I);
   }
----------------
Should this use the correct predicate too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114646/new/

https://reviews.llvm.org/D114646