[PATCH] D114385: [libunwind] Fix testing with sanitizers enabled

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 22:21:13 PST 2021


phosek added a comment.

In D114385#3160079 <https://reviews.llvm.org/D114385#3160079>, @leonardchan wrote:

> Ok I did more digging and it looks like the issue is that my host libc doesn't have an FDE for `raise`, but it does have one for `kill` (which I don't have an explanation for). I suppose that would mean D114743 <https://reviews.llvm.org/D114743> isn't a bad alternative, but I guess this means it could also fail again for any user with a libc that doesn't happen to have unwind info for `kill` (could be a wait-and-see scenario). If we want to avoid the potential missing unwind info altogether, we could perhaps having some inline assembly that does a bad memory reference, but that might not be very portable. Thoughts?

I'd just point out that the host libc in this case is glibc shipped with Ubuntu 18.04 on arm64 which is a popular distribution (although it's possible that arm64 version doesn't receive as much testing as amd64).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114385/new/

https://reviews.llvm.org/D114385



More information about the llvm-commits mailing list