[PATCH] D114397: [lld-macho] Mark dylib symbols coming from -weak_framework as weak-ref

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lld/MachO/Symbols.h:240-242
+  // Libraries and frameworks can be loaded multiple times with different
+  // forceWeakImport (eg., first loaded as strong then as weak)
+  // When that happens we must ensure the weak-property sticks.
----------------
Similar to our discussions about the commit message, I think there's some confusion here about what's getting fixed :) this has nothing to do with libraries being loaded multiple times...


================
Comment at: lld/test/MachO/weak-import.s:31
+
+## This refernces the gxx_personality_v0 symbol which is defined in libc++abi, which is then
+## reexported by libc++.
----------------



================
Comment at: lld/test/MachO/weak-import.s:33
+## reexported by libc++.
+## Checking that the weak-ref is preserved.
+# RUN: %lld -weak-lc++ %t/weak-reexport.o -o %t/weak-reexport.out
----------------
nit: nice to be a bit more specific...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114397/new/

https://reviews.llvm.org/D114397