[PATCH] D114558: [ASan] Shared optimized callbacks implementation.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/tests/asan_noinst_test.cpp:18-28
-#include <sanitizer/allocator_interface.h>
-
 #include <assert.h>
+#include <sanitizer/allocator_interface.h>
+#include <sanitizer_common/sanitizer_shadow_defines.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>  // for memset()
 #include <algorithm>
----------------
can you commit this line reordering separately and rebase the patch


================
Comment at: compiler-rt/lib/asan/tests/asan_noinst_test.cpp:351
+
+#if defined(SHADOW_OFFSET_STR)
+TEST(AddressSanitizer, TestShadowGlobalVar) {
----------------
I see  SHADOW_OFFSET_STR neither in existing code nor in the patch
Is some file is missing or another patch.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_shadow_defines.h:14
+
+#if SANITIZER_FUCHSIA
+#  define SHADOW_OFFSET_CONST 0
----------------
why it's in common? these constants are asan specific


================
Comment at: llvm/test/CodeGen/X86/asan-check-memaccess-add.ll:61
 ; CHECK-NOT:          push    %rbp
-; CHECK:              callq   __asan_check_load16_rn[[RN16:.*]]
-; CHECK:              callq   __asan_check_store16_rn[[RN16]]
+; CHECK:              callq   __asan_check_x86_64_load_add_16_[[REG16:.*]]
+; CHECK:              callq   __asan_check_x86_64_store_add_16_[[REG16]]
----------------
why do you need x86_64 in nname?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114558/new/

https://reviews.llvm.org/D114558