[PATCH] D114556: [DebugInfo] Do not replace existing nodes from DICompileUnit

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 17:05:16 PST 2021


ellis created this revision.
Herald added subscribers: dexonsmith, hiraditya.
ellis added a reviewer: dblaikie.
ellis added a project: debug-info.
ellis edited the summary of this revision.
ellis published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When creating a new DIBuilder with an existing DICompileUnit, load the
DINodes from the current DICompileUnit so they don't get overwritten.
This is done in the MachineOutliner pass, but it didn't change the CU so
the bug never appeared. We need this if we ever want to add DINodes to
the CU after it has been created, e.g., DIGlobalVariables.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114556

Files:
  llvm/lib/IR/DIBuilder.cpp
  llvm/unittests/IR/IRBuilderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114556.389576.patch
Type: text/x-patch
Size: 4518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211130/710af848/attachment.bin>


More information about the llvm-commits mailing list