[PATCH] D114305: [Demangle] Add support for multiple identifiers in D qualified names

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 16:50:37 PST 2021


ljmf00 added inline comments.


================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:149
+bool Demangler::isSymbolName(const char *Mangled) {
+  if (std::isdigit(*Mangled))
+    return true;
----------------
mehdi_amini wrote:
> This breaks the windows bots:  `C:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\lib\Demangle\DLangDemangle.cpp(125): error C2039: 'isdigit': is not a member of 'std'`
This got fixed on https://github.com/llvm/llvm-project/commit/bd4c6a476fd037fb07a1c484f75d93ee40713d3d


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114305/new/

https://reviews.llvm.org/D114305



More information about the llvm-commits mailing list