[PATCH] D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries.

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 16:14:17 PST 2021


snehasish marked an inline comment as done.
snehasish added a comment.

PTAL, thanks!



================
Comment at: llvm/test/tools/llvm-profdata/memprof-multi.test:35
+We expect 2 MIB entries, 1 each for the malloc calls in the program. Unlike the
+memprof-basic.test we do not see any allocation from glibc.
+
----------------
tejohnson wrote:
> Is this just dumb luck? Doesn't really matter since you have saved the profile, but might if we ever need to regenerate the profile as described above.
It is deterministic in behaviour if thats what you were implying. I'll take a closer look once I add symbolization support to llvm-profdata. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114286/new/

https://reviews.llvm.org/D114286



More information about the llvm-commits mailing list