[PATCH] D114307: [Demangle] Add support for D anonymous symbols

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 15:35:48 PST 2021


dblaikie added a comment.

> The reason for doing this early is also for performance reasons since other checks are not needed such as whether it is a template or a backreference. Other expensive checks should be avoided like when a number decoding overflows.

I wouldn't mind avoiding that sort of thing on the first pass & implementing it separately for optimization if/when/with data to show it's valuable, but no worries - if it complicates the code (such as avoiding the ".") that's enough justification for me not to go the other way that I was suggesting. Thanks for explaining!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114307/new/

https://reviews.llvm.org/D114307



More information about the llvm-commits mailing list