[PATCH] D114748: [ELF] Change -z unknown from error to warning

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 15:23:50 PST 2021


jrtc27 added a comment.

Probably worth pointing out this is what GNU ld does, so there's precedent (that's not just what Clang does)



================
Comment at: lld/test/ELF/driver.test:66
 ## Check we report "unknown -z value" error even with -v.
-# RUN: not ld.lld %t -z foo -v 2>&1 | FileCheck -check-prefix=ERR10 %s
+# RUN: ld.lld %t -z foo -v 2>&1 | FileCheck -check-prefix=ERR10 %s
 
----------------
Should there be --fatal-warnings versions of these? Might be overkill given it's just a call to `warn` but at the same time doesn't hurt to be extra safe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114748/new/

https://reviews.llvm.org/D114748



More information about the llvm-commits mailing list