[PATCH] D114327: [CMake] Installable find modules for terminfo and libffi

Jack Andersen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 15:13:48 PST 2021


jackoalan added a comment.

In D114327#3158666 <https://reviews.llvm.org/D114327#3158666>, @JDevlieghere wrote:

> I'm assuming the logic to find the actual packages is the same

Yes, mostly existing code refactored into find modules.

One minor difference is libffi is checked using `check_c_source_compiles` linking to symbol declarations rather than `check_symbol_exists`, so it is only concerned with the ability to successfully link. This is useful for distributions that ship headers in separate packages that the user may not have installed (and technically should not have to as a pre-built LLVM importer).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114327/new/

https://reviews.llvm.org/D114327



More information about the llvm-commits mailing list