[PATCH] D114664: [objcopy][NFC] Add rules to cmake to put files under specific folders.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 13:49:40 PST 2021


avl added inline comments.


================
Comment at: llvm/lib/Object/CMakeLists.txt:107-110
+  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Object/ObjCopy/COFF
+  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Object/ObjCopy/ELF
+  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Object/ObjCopy/MachO
+  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Object/ObjCopy/wasm
----------------
jhenderson wrote:
> Do you need these explicitly?
yes, we need these. If we do not specify include paths here then corresponding .h files would not be shown in the "Header Files" folder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114664/new/

https://reviews.llvm.org/D114664



More information about the llvm-commits mailing list