[PATCH] D114223: Make ScopedPrinter interface virtual

[Jayson Yan via Phabricator via llvm-commits]

Jaysonyan marked an inline comment as done.
Jaysonyan added inline comments.


================
Comment at: llvm/include/llvm/Support/ScopedPrinter.h:375
+
+  virtual void printRawFlagsImpl(StringRef Label, HexNumber Value,
+                                 ArrayRef<FlagEntry> Flags) {
----------------
jhenderson wrote:
> I'm not a fan of this function name. In some ways, it's less raw than the regular `printFlags` code, as it includes names. Any particular need for it to be a different name, or could we just make use of function overloading?
I've updated `printRawFlagsImpl` to share the `printFlagsImpl` name and take a list of HexNumbers instead of FlagEntry. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114223/new/

https://reviews.llvm.org/D114223