[PATCH] D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC

Mon Nov 29 13:45:35 PST 2021

tstellar added a comment.

@MaskRay This patch needs to change the default behavior to what it was prior to 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619>.  It does not look to me like the patch does this.  If I am wrong, please explain why.

We've been discussing this for too long already and need a conclusion.  In the release/13.x, I'm planning to revert 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> since we don't have any other proposed fix.

If we can't get a compromise patch approved by Thursday, I'm going to revert 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> in main too.  As I mentioned on the other thread, the idea behind 6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619 <https://reviews.llvm.org/rG6d2d3bd0a61f5fc7fd9f61f48bc30e9ca77cc619> was NAK'd, but it was committed anyway.  We need to follow community process around code review and revert back to the original behavior and then discuss the next steps afterwards.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114186/new/

https://reviews.llvm.org/D114186