[PATCH] D111533: [SCEV] Invalidate user SCEVs along with operand SCEVs to avoid cache corruption

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 13:13:13 PST 2021


reames added a comment.

In D111533#3159337 <https://reviews.llvm.org/D111533#3159337>, @nikic wrote:

> Just looking at the trace, I suspect we leave behind invalid SCEVs in ValuesAtScope. This is basically a `(SCEV, Loop) -> SCEV` map, and while we do clear entries if the SCEV on the left side is invalidated, we don't if the SCEV on the right is.

This is exactly correct.  I just finished confirming this experimentally when I saw your comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111533/new/

https://reviews.llvm.org/D111533



More information about the llvm-commits mailing list