[PATCH] D114397: [lld-macho] Mark dylib symbols coming from -weak_framework as weak-def.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added a comment.

In D114397#3159178 <https://reviews.llvm.org/D114397#3159178>, @int3 wrote:

> "weak" is an (unfortunately) overloaded term here. From reading ld64's manpage, it seems that "weak library" is just short for "weakly referenced library". There's nothing there that says that they contain weak definitions as well.

Ok, understood.  Since it's no undocumented territory,  do you 👎  or 👍 the weak-def change?

> And in the future please highlight any intentional deviations from ld64's behavior in the commit message :)

updated

>> done (real)
>
> Explanatory comment is done, but we still need a test involving a re-exported symbol




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114397/new/

https://reviews.llvm.org/D114397